---
id: change/bcapps/10088
type: change
title: "#10088 Harden base ruleset: promote 21 rules back to Error"
summary: 21 analyzer rules were promoted from Warning back to Error in the base ruleset after measuring violations across all country-specific builds, with source code fixes applied where needed to address the handful of violations found.
tier: official
language: en
tags:
  - refactor
  - main
  - bc30
  - codeunit intrastatreportmanagementde
  - page subcontracting order subform
  - report check
  - codeunit vat pmt. comm. xml generator
  - report electronic carta porte mx
  - xmlport ehf reminder 3.0
system: finance
review:
  state: reviewed
  by: opus
  at: "2026-10-08T02:09:33.228Z"
  flags: []
generated:
  at: "2026-10-08T01:26:53.141Z"
  pipeline: 0.2.0
  prompts:
    extract-change: 1
  input_hash: f53e391e5db610c29c0f1846e715836cf7a0cc85
evidence:
  - kind: code
    url: https://github.com/microsoft/BCApps/pull/10088
    title: "microsoft/BCApps#10088: Harden base ruleset: promote 21 rules back to Error"
    date: "2026-08-11"
    commit: f53e391e5db610c29c0f1846e715836cf7a0cc85
    t: null
    quote: null
links:
  learn: []
  objects:
    - object/codeunit/11029-de
    - object/page/18493-in
    - object/report/1401
    - object/codeunit/12150-it
    - object/report/10480-ca
    - object/xmlport/10601-no
  features: []
  topics: []
  localizations: []
  videos: []
  posts: []
  guidelines: []
  changes: []
number: 10088
repo: microsoft/BCApps
source_id: bcapps-prs
url: https://github.com/microsoft/BCApps/pull/10088
kind: pr
base_branch: main
major: "30"
merged_at: "2026-08-11T19:26:13Z"
author: JesperSchulz
author_type: User
community_contribution: false
labels:
  - "Ownership: Needs Review"
  - "Team: Other"
change_class: code
change_kind: refactor
behavior_change: false
breaking: false
files:
  count: 13
  additions: 32
  deletions: 117
  al: 8
apps:
  - Base Application
  - INGST
  - IntrastatDE
objects_touched:
  - key: codeunit/11029
    page: codeunit/11029-de
    type: codeunit
    id: 11029
    name: IntrastatReportManagementDE
    app: IntrastatDE
    status: modified
  - key: page/18493
    page: page/18493-in
    type: page
    id: 18493
    name: Subcontracting Order Subform
    app: INGST
    status: modified
  - key: report/1401
    page: report/1401
    type: report
    id: 1401
    name: Check
    app: Base Application
    status: modified
  - key: codeunit/12150
    page: codeunit/12150-it
    type: codeunit
    id: 12150
    name: VAT Pmt. Comm. XML Generator
    app: Base Application
    status: modified
  - key: report/10480
    page: report/10480-ca
    type: report
    id: 10480
    name: Electronic Carta Porte MX
    app: Base Application
    status: modified
  - key: xmlport/10601
    page: xmlport/10601-no
    type: xmlport
    id: 10601
    name: EHF Reminder 3.0
    app: Base Application
    status: modified
objects_unjoined:
  - path: src/Layers/NA/BaseApp/Sales/Document/SalesInvoice.Page.al
    status: modified
    reason: not-in-snapshot
  - path: src/Layers/NA/BaseApp/Sales/History/PostedSalesInvoices.Page.al
    status: modified
    reason: not-in-snapshot
obsoletions: []
backports: []
fixes_issues: []
work_items:
  - 640773
systems:
  - finance
  - integration
  - inventory
quote: null
joined_against:
  major: "30"
  commit: f18567dc08e2bd162bf192e1da4d714b57eb099f
---

# #10088 Harden base ruleset: promote 21 rules back to Error

> 21 analyzer rules were promoted from Warning back to Error in the base ruleset after measuring violations across all country-specific builds, with source code fixes applied where needed to address the handful of violations found.

[Pull request](https://github.com/microsoft/BCApps/pull/10088) · merged into `main` (BC30) on 2026-08-11 by JesperSchulz · 13 files (+32 -117), 8 AL · refactor · tier official · reviewed (checked by Opus)

## What changed

- 21 rules promoted from Warning to Error: AA0013, AA0189, AA0199, AA0213, AA0230, AA0604, AL0269, AL0424, AL0457, AL0482, AL0551, AL0590, AL0602, AL0775, AL0842, AS0075, AS0079, AS0111, AS0113, AS0126, PTE0017
- Small source fixes (Locked = true, begin placement, application area ordering and casing, redundant ShowAsTree) in 12 app and test files across several country layers
- AS0094, AL1026 and PTE0014 stay as Warning with justifications tied to legacy XML permission sets that still need converting
- Rules with zero violations were promoted outright; rules with a few violations were fixed at source first
- Base ruleset overrides reduced from 127 to 106

## AL objects touched

- [Codeunit 11029 "IntrastatReportManagementDE"](../../objects/codeunit/11029-de.md), IntrastatDE (DE layer): modified
- [Page 18493 "Subcontracting Order Subform"](../../objects/page/18493-in.md), INGST (IN layer): modified
- [Report 1401 "Check"](../../objects/report/1401.md), Base Application (GB layer): modified
- [Codeunit 12150 "VAT Pmt. Comm. XML Generator"](../../objects/codeunit/12150-it.md), Base Application (IT layer): modified
- [Report 10480 "Electronic Carta Porte MX"](../../objects/report/10480-ca.md), Base Application (CA layer): modified
- [XMLport 10601 "EHF Reminder 3.0"](../../objects/xmlport/10601-no.md), Base Application (NO layer): modified
- `src/Layers/NA/BaseApp/Sales/Document/SalesInvoice.Page.al`: modified, not in the BC30 snapshot
- `src/Layers/NA/BaseApp/Sales/History/PostedSalesInvoices.Page.al`: modified, not in the BC30 snapshot

## Context

- Work items: AB#640773
- Labels: Ownership: Needs Review, Team: Other
- Systems: finance, integration, inventory

Source: metadata of a merged pull request in microsoft/BCApps (bcapps): title, labels, changed paths and counts, with a summary in our words. No source text and no description beyond one short quote (D10, D61).