---
id: change/bcapps/10251
type: change
title: "#10251 Ruleset hardening: promote 5 rules from Warning to Error"
summary: Five analyzer rules (AL0547, AL0679, AW0014, AS0058, PTE0007) were promoted back to Error by removing their overrides from the base ruleset. Violations were fixed by adding a missing codeunit to a permission set and unhiding an action group, or suppressed with documented pragmas.
tier: official
language: en
tags:
  - refactor
  - main
  - bc30
  - permissionset email logging - obj.
  - codeunit workflow webhook notification
  - page incoming document
  - page incoming documents
system: integration
review:
  state: reviewed
  by: opus
  at: "2026-10-08T02:08:11.545Z"
  flags: []
generated:
  at: "2026-10-08T01:26:53.141Z"
  pipeline: 0.2.0
  prompts:
    extract-change: 1
  input_hash: c562b44f0e08e7e7f79f1d3a187cda64338a7bbe
evidence:
  - kind: code
    url: https://github.com/microsoft/BCApps/pull/10251
    title: "microsoft/BCApps#10251: Ruleset hardening: promote 5 rules from Warning to Error"
    date: "2026-08-19"
    commit: c562b44f0e08e7e7f79f1d3a187cda64338a7bbe
    t: null
    quote: null
links:
  learn: []
  objects:
    - object/permissionset/1680
    - object/codeunit/1545
    - object/page/189
    - object/page/190
  features: []
  topics: []
  localizations: []
  videos: []
  posts: []
  guidelines: []
  changes: []
number: 10251
repo: microsoft/BCApps
source_id: bcapps-prs
url: https://github.com/microsoft/BCApps/pull/10251
kind: pr
base_branch: main
major: "30"
merged_at: "2026-08-19T14:03:56Z"
author: JesperSchulz
author_type: User
community_contribution: false
labels:
  - "AL: Apps (W1)"
  - "Ownership: Needs Review"
  - "Team: Other"
change_class: code
change_kind: refactor
behavior_change: true
breaking: false
files:
  count: 20
  additions: 72
  deletions: 29
  al: 6
apps:
  - Base Application
  - EmailLogging
objects_touched:
  - key: permissionset/1680
    page: permissionset/1680
    type: permissionset
    id: 1680
    name: Email Logging - Obj.
    app: EmailLogging
    status: modified
  - key: codeunit/1545
    page: codeunit/1545
    type: codeunit
    id: 1545
    name: Workflow Webhook Notification
    app: Base Application
    status: modified
  - key: page/189
    page: page/189
    type: page
    id: 189
    name: Incoming Document
    app: Base Application
    status: modified
  - key: page/190
    page: page/190
    type: page
    id: 190
    name: Incoming Documents
    app: Base Application
    status: modified
objects_unjoined:
  - path: src/Layers/APAC/BaseApp/eServices/EDocument/IncomingDocument.Page.al
    status: modified
    reason: not-in-snapshot
  - path: src/Layers/ES/BaseApp/Finance/FinancialReports/AccountScheduleNames.Page.al
    status: modified
    reason: not-in-snapshot
obsoletions: []
backports: []
fixes_issues: []
work_items:
  - 640773
systems:
  - integration
  - crm
  - development
quote: null
joined_against:
  major: "30"
  commit: f18567dc08e2bd162bf192e1da4d714b57eb099f
---

# #10251 Ruleset hardening: promote 5 rules from Warning to Error

> Five analyzer rules (AL0547, AL0679, AW0014, AS0058, PTE0007) were promoted back to Error by removing their overrides from the base ruleset. Violations were fixed by adding a missing codeunit to a permission set and unhiding an action group, or suppressed with documented pragmas.

[Pull request](https://github.com/microsoft/BCApps/pull/10251) · merged into `main` (BC30) on 2026-08-19 by JesperSchulz · 20 files (+72 -29), 6 AL · refactor · tier official · reviewed (checked by Opus)

## What changed

- Promotes AL0547, AL0679, AW0014, AS0058 and PTE0007 to Error; override count drops from 100 to 95
- Adds the Email Logging Install codeunit to the Email Logging - Obj. permission set
- Removes Visible = false from the F&unctions group on the ES Account Schedule Names page so the promoted export action is reachable
- Suppresses AL0547 on published events and AS0058/PTE0007 on asserterror in test library codeunits with pragmas
- Keeps overrides for nine other rules that need broader remediation
- Behaviour changes for users or extensions.

## AL objects touched

- [Permission set 1680 "Email Logging - Obj."](../../objects/permissionset/1680.md), EmailLogging: modified
- [Codeunit 1545 "Workflow Webhook Notification"](../../objects/codeunit/1545.md), Base Application: modified
- [Page 189 "Incoming Document"](../../objects/page/189.md), Base Application: modified
- [Page 190 "Incoming Documents"](../../objects/page/190.md), Base Application: modified
- `src/Layers/APAC/BaseApp/eServices/EDocument/IncomingDocument.Page.al`: modified, not in the BC30 snapshot
- `src/Layers/ES/BaseApp/Finance/FinancialReports/AccountScheduleNames.Page.al`: modified, not in the BC30 snapshot

## Context

- Work items: AB#640773
- Labels: AL: Apps (W1), Ownership: Needs Review, Team: Other
- Systems: integration, crm, development

Source: metadata of a merged pull request in microsoft/BCApps (bcapps): title, labels, changed paths and counts, with a summary in our words. No source text and no description beyond one short quote (D10, D61).