BC Observatoryunofficial, made by waldo
code change · otherAL Developmentofficial - Microsoftreviewed - checked by Opus

#118 knowledge: 3 FP-suppression guards from BC apps negative feedback

Three knowledge articles are added to clarify AL facts that were incorrectly flagged by the review agent, suppressing false-positive findings for ObsoleteReason omissions, bare Get() calls, and OnAfterGetCurrRecord behavior.

Open in Claude118.mdPull request #118

Pull request · merged into main on 2026-07-21 by gggdttt · 3 files (+78 -0), 3 AL · other · tier official · reviewed (checked by Opus)

What changed

  • ObsoleteTag carries removal version; ObsoleteReason need not restate it
  • Bare Rec.Get() raises an error when record is missing, not silently ignored
  • OnAfterGetCurrRecord fires on current-record change, not per row; CalcFields there is not N+1
  • Articles follow existing negative-clarification style with false-positive keyword
  • Knowledge index grows from 245 to 248 entries

AL objects touched

  • microsoft/knowledge/error-handling/unchecked-get-throws-when-record-not-found.md: added, not in the BC? snapshot yet
  • microsoft/knowledge/performance/onaftergetcurrrecord-is-not-per-row.md: added, not in the BC? snapshot yet
  • microsoft/knowledge/upgrade/obsoletereason-need-not-restate-removal-version.md: added, not in the BC? snapshot yet

Context

  • Systems: development
  • From the description: “Each encodes an AL fact that the review agent got wrong, so the corresponding finding is suppressed going forward.”

Source: metadata of a merged pull request in microsoft/BCQuality (bcquality): title, labels, changed paths and counts, with a summary in our words. No source text and no description beyond one short quote (D10, D61).