---
id: change/bcquality/183
type: change
title: "#183 Add reporting review guidance and evaluation fixtures"
summary: Nine reporting rules and guidance articles have been added to the BCQuality knowledge base covering report variable clearing, CurrReport control flow, report extensions, table view narrowing, and request page cancellation.
tier: official
language: en
tags:
  - feature
  - main
system: reporting
review:
  state: reviewed
  by: opus
  at: "2026-10-08T02:05:14.057Z"
  flags: []
generated:
  at: "2026-10-08T01:26:53.141Z"
  pipeline: 0.2.0
  prompts:
    extract-change: 1
  input_hash: b545b22fb9173e0a1f17c3b2e02dc77ea6c92dab
evidence:
  - kind: code
    url: https://github.com/microsoft/BCQuality/pull/183
    title: "microsoft/BCQuality#183: Add reporting review guidance and evaluation fixtures"
    date: "2026-09-15"
    commit: b545b22fb9173e0a1f17c3b2e02dc77ea6c92dab
    t: null
    quote: This PR adds dedicated review coverage for AL reporting scenarios that were not previously represented in the BCQuality knowledge base.
links:
  learn: []
  objects: []
  features: []
  topics: []
  localizations: []
  videos: []
  posts: []
  guidelines: []
  changes: []
number: 183
repo: microsoft/BCQuality
source_id: bcquality-prs
url: https://github.com/microsoft/BCQuality/pull/183
kind: pr
base_branch: main
major: null
merged_at: "2026-09-15T08:38:33Z"
author: demiliani
author_type: User
community_contribution: false
labels: []
change_class: code
change_kind: feature
behavior_change: false
breaking: false
files:
  count: 31
  additions: 827
  deletions: 1
  al: 29
apps: []
objects_touched: []
objects_unjoined:
  - path: microsoft/knowledge/reporting/clear-report-variable-before-independent-runmodal.bad.al
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/clear-report-variable-before-independent-runmodal.good.al
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/clear-report-variable-before-independent-runmodal.md
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/currreport-break-ends-the-current-trigger.bad.al
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/currreport-break-ends-the-current-trigger.good.al
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/currreport-break-ends-the-current-trigger.md
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/currreport-quit-rolls-back-and-skips-onpostreport.bad.al
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/currreport-quit-rolls-back-and-skips-onpostreport.good.al
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/currreport-quit-rolls-back-and-skips-onpostreport.md
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/currreport-skip-does-not-stop-trigger-code.bad.al
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/currreport-skip-does-not-stop-trigger-code.good.al
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/currreport-skip-does-not-stop-trigger-code.md
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/report-output-in-a-loop-needs-one-client-download.bad.al
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/report-output-in-a-loop-needs-one-client-download.good.al
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/report-output-in-a-loop-needs-one-client-download.md
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/reportextension-dataitem-trigger-order-is-explicit.bad.al
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/reportextension-dataitem-trigger-order-is-explicit.good.al
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/reportextension-dataitem-trigger-order-is-explicit.md
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/reportextension-report-triggers-run-after-base-triggers.bad.al
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/reportextension-report-triggers-run-after-base-triggers.good.al
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/reportextension-report-triggers-run-after-base-triggers.md
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/settableview-cannot-broaden-dataitemtableview.bad.al
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/settableview-cannot-broaden-dataitemtableview.good.al
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/settableview-cannot-broaden-dataitemtableview.md
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/stop-when-runrequestpage-returns-empty-parameters.bad.al
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/stop-when-runrequestpage-returns-empty-parameters.good.al
    status: added
    reason: not-in-snapshot
  - path: microsoft/knowledge/reporting/stop-when-runrequestpage-returns-empty-parameters.md
    status: added
    reason: not-in-snapshot
  - path: microsoft/skills/review/al-code-review.md
    status: modified
    reason: not-in-snapshot
  - path: microsoft/skills/review/al-reporting-review.md
    status: added
    reason: not-in-snapshot
obsoletions: []
backports: []
fixes_issues: []
work_items: []
systems:
  - reporting
  - development
quote: This PR adds dedicated review coverage for AL reporting scenarios that were not previously represented in the BCQuality knowledge base.
joined_against:
  major: null
  commit: null
---

# #183 Add reporting review guidance and evaluation fixtures

> Nine reporting rules and guidance articles have been added to the BCQuality knowledge base covering report variable clearing, CurrReport control flow, report extensions, table view narrowing, and request page cancellation.

[Pull request](https://github.com/microsoft/BCQuality/pull/183) · merged into `main` on 2026-09-15 by demiliani · 31 files (+827 -1), 29 AL · feature · tier official · reviewed (checked by Opus)

## What changed

- Added nine new reporting rules addressing control-flow behavior and data handling in reports
- Included bad and good AL code samples for each rule to guide developers
- Created a dedicated reporting review skill with evidence-based review conditions to minimize false positives
- Integrated new rules into the main AL code review skill and evaluation fixtures
- Rules focus on preventing incorrect output, unintended side effects, and lost database changes

## AL objects touched

- `microsoft/knowledge/reporting/clear-report-variable-before-independent-runmodal.bad.al`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/clear-report-variable-before-independent-runmodal.good.al`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/clear-report-variable-before-independent-runmodal.md`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/currreport-break-ends-the-current-trigger.bad.al`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/currreport-break-ends-the-current-trigger.good.al`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/currreport-break-ends-the-current-trigger.md`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/currreport-quit-rolls-back-and-skips-onpostreport.bad.al`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/currreport-quit-rolls-back-and-skips-onpostreport.good.al`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/currreport-quit-rolls-back-and-skips-onpostreport.md`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/currreport-skip-does-not-stop-trigger-code.bad.al`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/currreport-skip-does-not-stop-trigger-code.good.al`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/currreport-skip-does-not-stop-trigger-code.md`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/report-output-in-a-loop-needs-one-client-download.bad.al`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/report-output-in-a-loop-needs-one-client-download.good.al`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/report-output-in-a-loop-needs-one-client-download.md`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/reportextension-dataitem-trigger-order-is-explicit.bad.al`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/reportextension-dataitem-trigger-order-is-explicit.good.al`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/reportextension-dataitem-trigger-order-is-explicit.md`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/reportextension-report-triggers-run-after-base-triggers.bad.al`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/reportextension-report-triggers-run-after-base-triggers.good.al`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/reportextension-report-triggers-run-after-base-triggers.md`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/settableview-cannot-broaden-dataitemtableview.bad.al`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/settableview-cannot-broaden-dataitemtableview.good.al`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/settableview-cannot-broaden-dataitemtableview.md`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/stop-when-runrequestpage-returns-empty-parameters.bad.al`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/stop-when-runrequestpage-returns-empty-parameters.good.al`: added, not in the BC? snapshot yet
- `microsoft/knowledge/reporting/stop-when-runrequestpage-returns-empty-parameters.md`: added, not in the BC? snapshot yet
- `microsoft/skills/review/al-code-review.md`: modified, not in the BC? snapshot
- `microsoft/skills/review/al-reporting-review.md`: added, not in the BC? snapshot yet

## Context

- Systems: reporting, development
- From the description: "This PR adds dedicated review coverage for AL reporting scenarios that were not previously represented in the BCQuality knowledge base."

Source: metadata of a merged pull request in microsoft/BCQuality (bcquality): title, labels, changed paths and counts, with a summary in our words. No source text and no description beyond one short quote (D10, D61).