--- id: change/bcquality/57 type: change title: "#57 Add source-verified Finance knowledge and review domain" summary: Adds a Microsoft-owned Finance knowledge domain with nine articles, each paired with bad and good AL samples, plus a new al-finance-review skill. The articles cover posting ledger entries, dimension sets, applying entries, due dates, reversals, journal balance and Normal VAT amounts. tier: official language: en tags: - feature - main system: finance review: state: reviewed by: opus at: "2026-10-08T02:04:27.895Z" flags: [] generated: at: "2026-10-08T01:26:53.141Z" pipeline: 0.2.0 prompts: extract-change: 1 input_hash: 07e324ddbc42597c479e041e06a7833740e05d0f evidence: - kind: code url: https://github.com/microsoft/BCQuality/pull/57 title: "microsoft/BCQuality#57: Add source-verified Finance knowledge and review domain" date: "2026-09-21" commit: 07e324ddbc42597c479e041e06a7833740e05d0f t: null quote: Nine atomic articles, eighteen original AL companions, and `al-finance-review`. links: learn: [] objects: [] features: [] topics: [] localizations: [] videos: [] posts: [] guidelines: [] changes: [] number: 57 repo: microsoft/BCQuality source_id: bcquality-prs url: https://github.com/microsoft/BCQuality/pull/57 kind: pr base_branch: main major: null merged_at: "2026-09-21T08:20:41Z" author: JesperSchulz author_type: User community_contribution: false labels: [] change_class: code change_kind: feature behavior_change: false breaking: false files: count: 93 additions: 2681 deletions: 118 al: 84 apps: [] objects_touched: [] objects_unjoined: - path: microsoft/knowledge/data-modeling/initialize-document-defaults-in-initrecord.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/data-modeling/initialize-document-defaults-in-initrecord.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/data-modeling/initialize-document-defaults-in-initrecord.md status: added reason: not-in-snapshot - path: microsoft/knowledge/data-modeling/round-direction-symbols-use-magnitude.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/data-modeling/round-direction-symbols-use-magnitude.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/data-modeling/round-direction-symbols-use-magnitude.md status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/apply-ledger-entries-through-application-codeunits.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/apply-ledger-entries-through-application-codeunits.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/apply-ledger-entries-through-application-codeunits.md status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/change-ledger-due-dates-through-entry-edit.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/change-ledger-due-dates-through-entry-edit.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/change-ledger-due-dates-through-entry-edit.md status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/do-not-edit-shared-dimension-sets.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/do-not-edit-shared-dimension-sets.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/do-not-edit-shared-dimension-sets.md status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/do-not-modify-or-delete-posted-ledger-entries.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/do-not-modify-or-delete-posted-ledger-entries.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/do-not-modify-or-delete-posted-ledger-entries.md status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/normal-vat-journal-amount-includes-vat.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/normal-vat-journal-amount-includes-vat.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/normal-vat-journal-amount-includes-vat.md status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/post-ledger-entries-through-posting-codeunits.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/post-ledger-entries-through-posting-codeunits.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/post-ledger-entries-through-posting-codeunits.md status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/preserve-journal-batch-document-balance.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/preserve-journal-batch-document-balance.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/preserve-journal-batch-document-balance.md status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/reverse-transactions-by-transaction-number.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/reverse-transactions-by-transaction-number.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/reverse-transactions-by-transaction-number.md status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/write-dimensions-as-dimension-set-entries.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/write-dimensions-as-dimension-set-entries.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/finance/write-dimensions-as-dimension-set-entries.md status: added reason: not-in-snapshot - path: microsoft/knowledge/interfaces/guard-interface-casts-with-is.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/interfaces/guard-interface-casts-with-is.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/interfaces/guard-interface-casts-with-is.md status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/cancel-reservations-through-reservation-management.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/cancel-reservations-through-reservation-management.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/cancel-reservations-through-reservation-management.md status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/carry-out-requisition-actions-through-the-standard-workflow.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/carry-out-requisition-actions-through-the-standard-workflow.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/carry-out-requisition-actions-through-the-standard-workflow.md status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/change-item-applications-through-posting-routines.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/change-item-applications-through-posting-routines.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/change-item-applications-through-posting-routines.md status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/post-item-ledger-changes-through-item-journals.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/post-item-ledger-changes-through-item-journals.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/post-item-ledger-changes-through-item-journals.md status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/post-revaluation-through-the-item-journal-batch.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/post-revaluation-through-the-item-journal-batch.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/post-revaluation-through-the-item-journal-batch.md status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/post-transfers-through-shipment-and-receipt-codeunits.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/post-transfers-through-shipment-and-receipt-codeunits.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/post-transfers-through-shipment-and-receipt-codeunits.md status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/reconcile-warehouse-adjustments-with-the-item-ledger.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/reconcile-warehouse-adjustments-with-the-item-ledger.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/reconcile-warehouse-adjustments-with-the-item-ledger.md status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/transfer-item-tracking-through-source-reservation-codeunits.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/transfer-item-tracking-through-source-reservation-codeunits.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/transfer-item-tracking-through-source-reservation-codeunits.md status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/use-date-aware-availability-for-promising.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/use-date-aware-availability-for-promising.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/scm/use-date-aware-availability-for-promising.md status: added reason: not-in-snapshot - path: microsoft/knowledge/style/dateformula-evaluate-needs-language-independent-literals.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/style/dateformula-evaluate-needs-language-independent-literals.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/style/dateformula-evaluate-needs-language-independent-literals.md status: added reason: not-in-snapshot - path: microsoft/knowledge/ui/dropdown-fieldgroup-respects-lookup-page-visibility.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/ui/dropdown-fieldgroup-respects-lookup-page-visibility.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/ui/dropdown-fieldgroup-respects-lookup-page-visibility.md status: added reason: not-in-snapshot - path: microsoft/knowledge/ui/updatepropagation-both-refreshes-main-page.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/ui/updatepropagation-both-refreshes-main-page.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/ui/updatepropagation-both-refreshes-main-page.md status: added reason: not-in-snapshot - path: microsoft/knowledge/upgrade/appversion-meaning-depends-on-execution-context.md status: added reason: not-in-snapshot - path: microsoft/knowledge/upgrade/install-and-upgrade-codeunits-have-no-order.bad.al status: added reason: not-in-snapshot - path: microsoft/knowledge/upgrade/install-and-upgrade-codeunits-have-no-order.good.al status: added reason: not-in-snapshot - path: microsoft/knowledge/upgrade/install-and-upgrade-codeunits-have-no-order.md status: added reason: not-in-snapshot - path: microsoft/skills/review/al-code-review.md status: modified reason: not-in-snapshot - path: microsoft/skills/review/al-data-modeling-review.md status: modified reason: not-in-snapshot - path: microsoft/skills/review/al-finance-review.md status: added reason: not-in-snapshot - path: microsoft/skills/review/al-interfaces-review.md status: modified reason: not-in-snapshot - path: microsoft/skills/review/al-scm-review.md status: added reason: not-in-snapshot - path: microsoft/skills/review/al-style-review.md status: modified reason: not-in-snapshot - path: microsoft/skills/review/al-ui-review.md status: modified reason: not-in-snapshot - path: microsoft/skills/review/al-upgrade-review.md status: modified reason: not-in-snapshot obsoletions: [] backports: [] fixes_issues: [] work_items: [] systems: - finance - development quote: Nine atomic articles, eighteen original AL companions, and `al-finance-review`. joined_against: major: null commit: null --- # #57 Add source-verified Finance knowledge and review domain > Adds a Microsoft-owned Finance knowledge domain with nine articles, each paired with bad and good AL samples, plus a new al-finance-review skill. The articles cover posting ledger entries, dimension sets, applying entries, due dates, reversals, journal balance and Normal VAT amounts. [Pull request](https://github.com/microsoft/BCQuality/pull/57) · merged into `main` on 2026-09-21 by JesperSchulz · 93 files (+2681 -118), 84 AL · feature · tier official · reviewed (checked by Opus) ## What changed - Nine Finance articles with eighteen bad/good AL sample companions - Rules target mistakes like direct ledger modification, copying only shortcut dimensions and fabricated settlement via status flags - New al-finance-review skill for reviewing code in the Finance domain - Finance owns G/L, customer/vendor, detailed and VAT records; item, value and warehouse records stay with SCM - All Finance articles use application-area all; leaf-count diagnostics follow the conventions from #192 ## AL objects touched - `microsoft/knowledge/data-modeling/initialize-document-defaults-in-initrecord.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/data-modeling/initialize-document-defaults-in-initrecord.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/data-modeling/initialize-document-defaults-in-initrecord.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/data-modeling/round-direction-symbols-use-magnitude.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/data-modeling/round-direction-symbols-use-magnitude.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/data-modeling/round-direction-symbols-use-magnitude.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/apply-ledger-entries-through-application-codeunits.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/apply-ledger-entries-through-application-codeunits.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/apply-ledger-entries-through-application-codeunits.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/change-ledger-due-dates-through-entry-edit.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/change-ledger-due-dates-through-entry-edit.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/change-ledger-due-dates-through-entry-edit.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/do-not-edit-shared-dimension-sets.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/do-not-edit-shared-dimension-sets.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/do-not-edit-shared-dimension-sets.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/do-not-modify-or-delete-posted-ledger-entries.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/do-not-modify-or-delete-posted-ledger-entries.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/do-not-modify-or-delete-posted-ledger-entries.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/normal-vat-journal-amount-includes-vat.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/normal-vat-journal-amount-includes-vat.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/normal-vat-journal-amount-includes-vat.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/post-ledger-entries-through-posting-codeunits.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/post-ledger-entries-through-posting-codeunits.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/post-ledger-entries-through-posting-codeunits.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/preserve-journal-batch-document-balance.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/preserve-journal-batch-document-balance.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/preserve-journal-batch-document-balance.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/reverse-transactions-by-transaction-number.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/reverse-transactions-by-transaction-number.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/reverse-transactions-by-transaction-number.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/write-dimensions-as-dimension-set-entries.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/write-dimensions-as-dimension-set-entries.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/finance/write-dimensions-as-dimension-set-entries.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/interfaces/guard-interface-casts-with-is.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/interfaces/guard-interface-casts-with-is.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/interfaces/guard-interface-casts-with-is.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/cancel-reservations-through-reservation-management.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/cancel-reservations-through-reservation-management.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/cancel-reservations-through-reservation-management.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/carry-out-requisition-actions-through-the-standard-workflow.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/carry-out-requisition-actions-through-the-standard-workflow.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/carry-out-requisition-actions-through-the-standard-workflow.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/change-item-applications-through-posting-routines.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/change-item-applications-through-posting-routines.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/change-item-applications-through-posting-routines.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/post-item-ledger-changes-through-item-journals.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/post-item-ledger-changes-through-item-journals.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/post-item-ledger-changes-through-item-journals.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/post-revaluation-through-the-item-journal-batch.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/post-revaluation-through-the-item-journal-batch.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/post-revaluation-through-the-item-journal-batch.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/post-transfers-through-shipment-and-receipt-codeunits.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/post-transfers-through-shipment-and-receipt-codeunits.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/post-transfers-through-shipment-and-receipt-codeunits.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/reconcile-warehouse-adjustments-with-the-item-ledger.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/reconcile-warehouse-adjustments-with-the-item-ledger.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/reconcile-warehouse-adjustments-with-the-item-ledger.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/transfer-item-tracking-through-source-reservation-codeunits.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/transfer-item-tracking-through-source-reservation-codeunits.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/transfer-item-tracking-through-source-reservation-codeunits.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/use-date-aware-availability-for-promising.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/use-date-aware-availability-for-promising.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/scm/use-date-aware-availability-for-promising.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/style/dateformula-evaluate-needs-language-independent-literals.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/style/dateformula-evaluate-needs-language-independent-literals.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/style/dateformula-evaluate-needs-language-independent-literals.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/ui/dropdown-fieldgroup-respects-lookup-page-visibility.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/ui/dropdown-fieldgroup-respects-lookup-page-visibility.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/ui/dropdown-fieldgroup-respects-lookup-page-visibility.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/ui/updatepropagation-both-refreshes-main-page.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/ui/updatepropagation-both-refreshes-main-page.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/ui/updatepropagation-both-refreshes-main-page.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/upgrade/appversion-meaning-depends-on-execution-context.md`: added, not in the BC? snapshot yet - `microsoft/knowledge/upgrade/install-and-upgrade-codeunits-have-no-order.bad.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/upgrade/install-and-upgrade-codeunits-have-no-order.good.al`: added, not in the BC? snapshot yet - `microsoft/knowledge/upgrade/install-and-upgrade-codeunits-have-no-order.md`: added, not in the BC? snapshot yet - `microsoft/skills/review/al-code-review.md`: modified, not in the BC? snapshot - `microsoft/skills/review/al-data-modeling-review.md`: modified, not in the BC? snapshot - `microsoft/skills/review/al-finance-review.md`: added, not in the BC? snapshot yet - `microsoft/skills/review/al-interfaces-review.md`: modified, not in the BC? snapshot - `microsoft/skills/review/al-scm-review.md`: added, not in the BC? snapshot yet - `microsoft/skills/review/al-style-review.md`: modified, not in the BC? snapshot - `microsoft/skills/review/al-ui-review.md`: modified, not in the BC? snapshot - `microsoft/skills/review/al-upgrade-review.md`: modified, not in the BC? snapshot ## Context - Systems: finance, development - From the description: "Nine atomic articles, eighteen original AL companions, and `al-finance-review`." Source: metadata of a merged pull request in microsoft/BCQuality (bcquality): title, labels, changed paths and counts, with a summary in our words. No source text and no description beyond one short quote (D10, D61).