#57 Add source-verified Finance knowledge and review domain
Adds a Microsoft-owned Finance knowledge domain with nine articles, each paired with bad and good AL samples, plus a new al-finance-review skill. The articles cover posting ledger entries, dimension sets, applying entries, due dates, reversals, journal balance and Normal VAT amounts.
- 93files
- 84AL files
- 0objects
Pull request · merged into main on 2026-09-21 by JesperSchulz · 93 files (+2681 -118), 84 AL · feature · tier official · reviewed (checked by Opus)
What changed
- Nine Finance articles with eighteen bad/good AL sample companions
- Rules target mistakes like direct ledger modification, copying only shortcut dimensions and fabricated settlement via status flags
- New al-finance-review skill for reviewing code in the Finance domain
- Finance owns G/L, customer/vendor, detailed and VAT records; item, value and warehouse records stay with SCM
- All Finance articles use application-area all; leaf-count diagnostics follow the conventions from #192
AL objects touched
microsoft/knowledge/data-modeling/initialize-document-defaults-in-initrecord.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/data-modeling/initialize-document-defaults-in-initrecord.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/data-modeling/initialize-document-defaults-in-initrecord.md: added, not in the BC? snapshot yetmicrosoft/knowledge/data-modeling/round-direction-symbols-use-magnitude.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/data-modeling/round-direction-symbols-use-magnitude.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/data-modeling/round-direction-symbols-use-magnitude.md: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/apply-ledger-entries-through-application-codeunits.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/apply-ledger-entries-through-application-codeunits.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/apply-ledger-entries-through-application-codeunits.md: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/change-ledger-due-dates-through-entry-edit.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/change-ledger-due-dates-through-entry-edit.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/change-ledger-due-dates-through-entry-edit.md: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/do-not-edit-shared-dimension-sets.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/do-not-edit-shared-dimension-sets.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/do-not-edit-shared-dimension-sets.md: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/do-not-modify-or-delete-posted-ledger-entries.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/do-not-modify-or-delete-posted-ledger-entries.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/do-not-modify-or-delete-posted-ledger-entries.md: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/normal-vat-journal-amount-includes-vat.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/normal-vat-journal-amount-includes-vat.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/normal-vat-journal-amount-includes-vat.md: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/post-ledger-entries-through-posting-codeunits.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/post-ledger-entries-through-posting-codeunits.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/post-ledger-entries-through-posting-codeunits.md: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/preserve-journal-batch-document-balance.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/preserve-journal-batch-document-balance.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/preserve-journal-batch-document-balance.md: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/reverse-transactions-by-transaction-number.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/reverse-transactions-by-transaction-number.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/reverse-transactions-by-transaction-number.md: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/write-dimensions-as-dimension-set-entries.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/write-dimensions-as-dimension-set-entries.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/finance/write-dimensions-as-dimension-set-entries.md: added, not in the BC? snapshot yetmicrosoft/knowledge/interfaces/guard-interface-casts-with-is.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/interfaces/guard-interface-casts-with-is.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/interfaces/guard-interface-casts-with-is.md: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/cancel-reservations-through-reservation-management.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/cancel-reservations-through-reservation-management.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/cancel-reservations-through-reservation-management.md: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/carry-out-requisition-actions-through-the-standard-workflow.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/carry-out-requisition-actions-through-the-standard-workflow.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/carry-out-requisition-actions-through-the-standard-workflow.md: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/change-item-applications-through-posting-routines.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/change-item-applications-through-posting-routines.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/change-item-applications-through-posting-routines.md: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/post-item-ledger-changes-through-item-journals.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/post-item-ledger-changes-through-item-journals.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/post-item-ledger-changes-through-item-journals.md: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/post-revaluation-through-the-item-journal-batch.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/post-revaluation-through-the-item-journal-batch.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/post-revaluation-through-the-item-journal-batch.md: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/post-transfers-through-shipment-and-receipt-codeunits.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/post-transfers-through-shipment-and-receipt-codeunits.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/post-transfers-through-shipment-and-receipt-codeunits.md: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/reconcile-warehouse-adjustments-with-the-item-ledger.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/reconcile-warehouse-adjustments-with-the-item-ledger.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/reconcile-warehouse-adjustments-with-the-item-ledger.md: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/transfer-item-tracking-through-source-reservation-codeunits.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/transfer-item-tracking-through-source-reservation-codeunits.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/transfer-item-tracking-through-source-reservation-codeunits.md: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/use-date-aware-availability-for-promising.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/use-date-aware-availability-for-promising.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/scm/use-date-aware-availability-for-promising.md: added, not in the BC? snapshot yetmicrosoft/knowledge/style/dateformula-evaluate-needs-language-independent-literals.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/style/dateformula-evaluate-needs-language-independent-literals.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/style/dateformula-evaluate-needs-language-independent-literals.md: added, not in the BC? snapshot yetmicrosoft/knowledge/ui/dropdown-fieldgroup-respects-lookup-page-visibility.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/ui/dropdown-fieldgroup-respects-lookup-page-visibility.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/ui/dropdown-fieldgroup-respects-lookup-page-visibility.md: added, not in the BC? snapshot yetmicrosoft/knowledge/ui/updatepropagation-both-refreshes-main-page.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/ui/updatepropagation-both-refreshes-main-page.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/ui/updatepropagation-both-refreshes-main-page.md: added, not in the BC? snapshot yetmicrosoft/knowledge/upgrade/appversion-meaning-depends-on-execution-context.md: added, not in the BC? snapshot yetmicrosoft/knowledge/upgrade/install-and-upgrade-codeunits-have-no-order.bad.al: added, not in the BC? snapshot yetmicrosoft/knowledge/upgrade/install-and-upgrade-codeunits-have-no-order.good.al: added, not in the BC? snapshot yetmicrosoft/knowledge/upgrade/install-and-upgrade-codeunits-have-no-order.md: added, not in the BC? snapshot yetmicrosoft/skills/review/al-code-review.md: modified, not in the BC? snapshotmicrosoft/skills/review/al-data-modeling-review.md: modified, not in the BC? snapshotmicrosoft/skills/review/al-finance-review.md: added, not in the BC? snapshot yetmicrosoft/skills/review/al-interfaces-review.md: modified, not in the BC? snapshotmicrosoft/skills/review/al-scm-review.md: added, not in the BC? snapshot yetmicrosoft/skills/review/al-style-review.md: modified, not in the BC? snapshotmicrosoft/skills/review/al-ui-review.md: modified, not in the BC? snapshotmicrosoft/skills/review/al-upgrade-review.md: modified, not in the BC? snapshot
Context
- Systems: finance, development
- From the description: “Nine atomic articles, eighteen original AL companions, and
al-finance-review.”
Source: metadata of a merged pull request in microsoft/BCQuality (bcquality): title, labels, changed paths and counts, with a summary in our words. No source text and no description beyond one short quote (D10, D61).